Fix/update service deletion #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohandast52
approved these changes
Feb 23, 2024
|
|
||
| // Set agent funding requirements | ||
| if (_service.chain_data?.instances) { | ||
| if (service.chain_data?.instances) { |
There was a problem hiding this comment.
You might consider adding it to a new variable since it is used in more than one place.
Suggested change
| if (service.chain_data?.instances) { | |
| const instances = service.chain_data?.instances; | |
| if (instances) { |
| setIsStaking(true); | ||
| setSpawnScreenState(nextPage); | ||
| const service: Service | undefined = await create(true); | ||
| if (!service) { |
There was a problem hiding this comment.
It's not a big deal, but we could reverse this for better readability.
if (service) { // positive... }
else { // error... }|
|
||
| await updateServiceState(service.hash).catch(() => | ||
| message.error('Failed to update service state'), | ||
| ); |
There was a problem hiding this comment.
usage of await and catch 🙈, can avoid any one, preferably catch.
| const newServices = [...prev]; | ||
| newServices[index] = service; | ||
| return newServices; | ||
| }), |
There was a problem hiding this comment.
do we want to catch and log an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
active:falseuntil deletion is resolved on backend side