Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve update service logic #196

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Improve update service logic #196

merged 1 commit into from
Jun 28, 2024

Conversation

jmoreira-valory
Copy link
Collaborator

  • Improve update service logic - deletion of old service folders
  • Added some safeguard logic in the process
  • Added further logging on update service logic

solarw
solarw approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@solarw solarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmoreira-valory jmoreira-valory merged commit afc92da into main Jun 28, 2024
4 checks passed
@oaksprout oaksprout linked an issue Jul 1, 2024 that may be closed by this pull request
Login button gets stuck loading #199
Closed
@jmoreira-valory jmoreira-valory deleted the chore/delete_service_exceptions branch November 13, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solarw solarw solarw approved these changes

@truemiller truemiller truemiller approved these changes

@dagacha dagacha dagacha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login button gets stuck loading
4 participants
@jmoreira-valory @solarw @truemiller @dagacha