Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splash window dimensions and add loading screen #22

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

truemiller
Copy link
Collaborator

Updated splash screen to reflect designs

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH, will it not work without this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this css is specifically for the splash page, and as we're not using react for the splash page, just some vanilla js, this contains the styles for text and spinner; could potentially extract just those styles however they're quite interwoven.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok!!

@truemiller truemiller merged commit 9ad3d3c into main Feb 26, 2024
2 checks passed
@mohandast52 mohandast52 deleted the refactor-splash-screen branch February 27, 2024 14:57
0xArdi pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants