Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with notifications:
I changed the logic to get the
minimumStakedAmountRequired
from the template instead of from the service and removed it from theuseReward
since it's not used anywhere else. I also updated the NeedsFunds modal so it has the same source of truth.The error:
After the fix:
2)The "first staking rewards earned" notification is shown for me multiple times in a row until the modal is closed. It happens due to the fact that useEffect has availableRewardsForEpochEth in its dependencies, which is slightly updated with every balance request that happens by interval. I used a ref here to get the first value, so the showNotification is only triggered once.