feat: "Start Agent" button fix #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mohandast52
commented
Jul 18, 2024
•
mohandast52
commented
- "Start Agent" button was repeated three times, causing the loading and other states to be deprioritized due to overlapping conditions.
- Refactored the code to have a single "Start Agent" button at the bottom and added props in the condition.
- It should work exactly the same as before and especially show different states when the "Start Agent" button is clicked after eviction.
truemiller
reviewed
Jul 18, 2024
| </Button> | ||
| ); | ||
| } | ||
| const canActivateAgent = canStartAgent && (isAgentEvicted || isDeployable); |
There was a problem hiding this comment.
getting lost with these can variables, they need more context
i.e. canStartAgent is not solely determined by the staking contract, and needs to be renamed to something more fitting, unsure what exactly but it should infer it's relation to the staking contract
canActivateAgent, i'm lost on what this represents too :/ canStartAgent already factors in isAgentEvicted
truemiller
reviewed
Jul 18, 2024
truemiller
approved these changes
Jul 19, 2024
Tanya-atatakai
approved these changes
Jul 19, 2024
oaksprout
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.