add download binaries script #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truemiller
reviewed
Jul 24, 2024
package.json
Outdated
| @@ -52,9 +51,10 @@ | |||
| "install:backend": "poetry install --no-root", | |||
| "install:frontend": "cd frontend && yarn", | |||
| "lint:frontend": "cd frontend && yarn lint", | |||
| "start": "electron .", | |||
| "start": "dotenv -e .env -- yarn electron .", | |||
There was a problem hiding this comment.
Suggested change
| "start": "dotenv -e .env -- yarn electron .", | |
| "start": "yarn electron .", | |
| "dev": "dotenv -e .env -- yarn start", |
There was a problem hiding this comment.
seperating these as I'm not sure how it will function in production mode for now; in production the envs are passed as expected. it's mostly dev where there are discrepancies around env variables
truemiller
reviewed
Jul 24, 2024
truemiller
reviewed
Jul 25, 2024
package.json
Outdated
| "start:frontend": "cd frontend && yarn start", | ||
| "test:frontend": "cd frontend && yarn test" | ||
| "test:frontend": "cd frontend && yarn test", | ||
| "download-binaries": "sh download_binaries.sh x64" |
There was a problem hiding this comment.
apologies @SarthakDev12, could you please make this download both binaries?
x64 and the arm64 variant too?
fine to run curl twice here, and remove the x64 from the script
truemiller
approved these changes
Jul 25, 2024
0xArdi
approved these changes
Jul 25, 2024
jmoreira-valory
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Ticket : https://trello.com/c/8sADgND3/1992-add-binary-download-step-to-yarn-build-sarthak
Description: add download binaries script.