Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more xDAI prompt #244

Merged
merged 13 commits into from
Aug 2, 2024
Merged

feat: Add more xDAI prompt #244

merged 13 commits into from
Aug 2, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Jul 24, 2024

context:

  • we only need two states for now: Fine & Too low - this shows when the master safe xdai balance is less than 2 xdai
  • show system notification the moment the trading balance has fallen too low. Text: "Trading balance is too low"
  • add check to Start Agent button – if the agent is not running and the balance is too low, disable Start Agent button

Design

Screenshot

Changes

notification text

@mohandast52 mohandast52 added the enhancement New feature or request label Jul 24, 2024
@mohandast52 mohandast52 self-assigned this Jul 24, 2024
@mohandast52 mohandast52 marked this pull request as ready for review July 25, 2024 14:12
Copy link
Collaborator

@truemiller truemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!
non-blocking, but consideration for UX/product, perhaps we include a grey Dot while the balance is not loaded?

@mohandast52
Copy link
Collaborator Author

@truemiller, We already have a loader if the balance hasn't been loaded yet. Here's the code.

@oaksprout oaksprout merged commit 39703ab into staging Aug 2, 2024
4 checks passed
@oaksprout oaksprout deleted the mohan/low-balance-prompt branch August 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants