Script for building middleware binary locally #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
reviewed
Aug 6, 2024
| @@ -0,0 +1,27 @@ | |||
| cd "$(dirname "$0")" | |||
There was a problem hiding this comment.
We need the valory header here. Example
0xArdi
reviewed
Aug 6, 2024
| @@ -0,0 +1,27 @@ | |||
| cd "$(dirname "$0")" | |||
|
|
|||
| BIN_DIR="electron/bins/" | |||
There was a problem hiding this comment.
You need to download the trader binary here. Check this step.
There was a problem hiding this comment.
I have created a different script for downloading trader binaries, in the same directory
There was a problem hiding this comment.
Alright, all good. You are missing the header there as well.
There was a problem hiding this comment.
Okay, I'll add it there as well
0xArdi
requested changes
Aug 6, 2024
SarthakDev12
force-pushed
the
feat/build_middleware_binary
branch
from
e8c1519 to
41adfb5
Compare
0xArdi
approved these changes
Aug 7, 2024
solarw
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Ticket: https://trello.com/c/tumGdJxq/2020-script-to-build-the-operate-cli-into-pyinstaller-binary-enables-local-testing-in-production-mode