Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete refactor #27

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Delete refactor #27

merged 4 commits into from
Feb 28, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Feb 28, 2024 •
edited
Loading

  • fixes rpc error badge showing before isRpcValid check it performed
  • removed update status call after deleting a service
  • remove service context filtering for only {active:true} services
  • added deleteServiceState to hook to delete service from state
  • update lock files

@truemiller truemiller merged commit d0eceb2 into main Feb 28, 2024
2 checks passed
@truemiller truemiller deleted the delete-refactor branch February 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 mohandast52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@truemiller @mohandast52