Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update low gas alert logic #277

Merged
merged 2 commits into from
Aug 20, 2024
Merged

chore: update low gas alert logic #277

merged 2 commits into from
Aug 20, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai commented Aug 14, 2024 •
edited
Loading

The change is based on this logic: #273 (comment)

How it works:

  1. when master safe balance is 1 XDAI, but agent safe has funds, e.g. 5 XDAI - we don't show the alert, notification, red dot, etc.
image
  1. when master safe balance is 1XDAI, and agent safe balance is 0.25 XDA, we show all the low gas info
image

@Tanya-atatakai Tanya-atatakai changed the base branch from main to staging August 14, 2024 07:52
mohandast52
mohandast52 approved these changes Aug 14, 2024
View reviewed changes
frontend/constants/thresholds.ts Outdated Show resolved Hide resolved
frontend/context/BalanceProvider.tsx Show resolved Hide resolved
@Tanya-atatakai Tanya-atatakai merged commit 45ad9f4 into staging Aug 20, 2024
3 of 4 checks passed
@Tanya-atatakai Tanya-atatakai deleted the tanya/low-gas-alert branch August 20, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truemiller truemiller truemiller approved these changes

@mohandast52 mohandast52 mohandast52 approved these changes

@oaksprout oaksprout Awaiting requested review from oaksprout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tanya-atatakai @mohandast52 @truemiller