Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Spawn and add Master Wallet funding screen #30

Merged
merged 29 commits into from
Mar 4, 2024
Merged

Refactor Spawn and add Master Wallet funding screen #30

merged 29 commits into from
Mar 4, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Mar 1, 2024 •
edited
Loading

  • extended funding component for use with non-agent funding, i.e. master wallet funding
  • added master wallet funding page
  • moved the majority of state to useSpawn hook and context
  • refactored spawn components to use useSpawn hook
  • made useEthers and useMulticall into services as they dont rely on state
  • added more validation to rpc so user can't pass //localhost... which breaks backend
  • remove reliance on service in spawning, as its not relevant
  • renamed maps to records as they're records

@truemiller truemiller changed the title Add SpawnMasterWalletFunding component Master wallet funding screen Mar 1, 2024
truemiller added 26 commits March 1, 2024 19:07
@truemiller
Refactor SpawnAgentFunding component to use useSpawn hook
2483137
@truemiller
Refactor resetSpawnScreenState to resetSpawn and update related code
7ab6a43
@truemiller
Refactor SpawnMasterWalletFunding component
db565dc
@truemiller
Refactor SpawnRPC component and update dependencies
c7ce2ca
@truemiller
Refactor SpawnStakingCheck component
dd2c8f8
@truemiller
Refactor Funding component and update dependencies
e3efe80
@truemiller
Refactor FundRequirement component to remove unused code and update v…
d65a34e 
…ariable names
@truemiller
Refactor FundRequirementERC20 component to use EthersService for ERC2…
17cfcd0 
…0 balance retrieval
@truemiller
Refactor FundRequirementETH component
83a1056
@truemiller
Refactor ServiceCard component and remove unused code
846e392
@truemiller
Update ServiceCardTotalBalance component imports and state types
f02dc59
@truemiller
Remove SpawnProvider test file
ab92837
@truemiller
Refactor SpawnProvider component to use SpawnData context
21dfdad
@truemiller
Update enum exports in frontend
a3c45b9
@truemiller
Add SpawnScreen enum
946cebc
@truemiller
Delete SpawnScreenState enum
1bbe8f2
@truemiller
Remove unused hooks
d344dfc
@truemiller
Delete unused hooks useEthers and useMulticall
606f9e3
@truemiller
Add useMasterWallet hook and update useServices and useSpawn hooks
69bcfe9
@truemiller
Refactor SpawnPage component and dependencies
b951208
@truemiller
Add Ethers and Multicall services
cbf4844
@truemiller
Remove unused Maps.ts file
c7875b6
@truemiller
Add address number and boolean record types
fd674c3
@truemiller
Update FundRequirement.tsx to use AddressNumberRecord instead of Fund…
8ce5df8 
…sReceivedMap
@truemiller
Update types and setReceivedFunds in FundRequirement component
a7a5b55
@truemiller
Remove commented code in SpawnStakingCheck.tsx
abdfa9a
@truemiller truemiller requested a review from mohandast52 March 1, 2024 19:22
@truemiller truemiller changed the title Master wallet funding screen Refactor Spawn and add Master Wallet funding screen Mar 1, 2024
mohandast52
mohandast52 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few tiny comments.

frontend/components/Spawn/SpawnRPC.tsx Outdated Show resolved Hide resolved
frontend/components/Spawn/SpawnStakingCheck.tsx Outdated Show resolved Hide resolved
frontend/hooks/useSpawn.tsx Show resolved Hide resolved
frontend/service/Ethers.ts Show resolved Hide resolved
@truemiller truemiller merged commit 4cd4e08 into main Mar 4, 2024
2 checks passed
@mohandast52 mohandast52 deleted the master-wallet-funding-screen branch March 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 mohandast52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@truemiller @mohandast52