Add support for funding service accounts automatically #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilelaf
reviewed
Apr 3, 2024
Comment on lines
18
to
20
| fund_requirements: { | ||
| agent: 0.1, | ||
| safe: 0.5, | ||
| agent: 1000000000000000000, | ||
| safe: 5000000000000000000, |
There was a problem hiding this comment.
Just a small recommendation, but not required to implement: amount variable names should include the name of whatever they hold. I.e.: fund_requirements_wei so it is harder to make mistakes.
dvilelaf
approved these changes
Apr 3, 2024
truemiller
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.