Feat/wallet integration #49
Conversation
| * Returns a list of available wallets | ||
| */ | ||
| const getWallets = async () => | ||
| fetch(`${BACKEND_URL}/wallet`).then((res) => res.json()); |
There was a problem hiding this comment.
do you want to catch any errors?
There was a problem hiding this comment.
no, this is intended.
if we catch it here it will alter the promises used later on, and potentially return a "fulfilled" status.
if for example the promise uses a chained .then() after this it will execute as the catch statement will fulfill
for example:
fetch(NaN).then(()=> 1).catch(()=>2).then(()=>3)
returns 3
frontend/context/WalletProvider.tsx
Outdated
| const updateBalance = useCallback(async () => { | ||
| const walletsToCheck: Address[] = []; | ||
| for (const wallet of wallets) { | ||
| if (!getAddress || !wallet.address) continue; |
There was a problem hiding this comment.
it's harder to understand negative conditions, can we change it? (and for 47 line as well)
| if (!getAddress || !wallet.address) continue; | |
| if (getAddress && wallet.address) { | |
| walletsToCheck.push(wallet.address); | |
| } |
There was a problem hiding this comment.
i tend to use guard clauses, to exit quickly, avoid future nesting, brackets .etc
will do my best to avoid negative conditions in future
Co-authored-by: Mohan <[email protected]>
…operate-app into feat/wallet-integration
…ction in WalletProvider
There was a problem hiding this comment.
LGTM 🎉 thanks @truemiller for addressing all the review requests 🙌
Integrated new Wallet/Account management endpoints