Fix safe funding #52
Merged
Fix safe funding #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybayblade
force-pushed
the
fix/safe-funding
branch
from
e00b541 to
af36a96
Compare
angrybayblade
commented
Apr 11, 2024
Comment on lines
+141
to
+142
| tx_nonce="0x", | ||
| chain_id=chain_type.id, |
There was a problem hiding this comment.
basically the tx params were wrong
dvilelaf
approved these changes
Apr 11, 2024
angrybayblade
commented
Apr 11, 2024
| @@ -374,14 +376,18 @@ def fund_service(self, hash: str) -> None: | |||
| chain_type=service.ledger_config.chain, | |||
| ) | |||
|
|
|||
| self.logger.info("Funding safe") | |||
| safe_balanace = ledger_api.get_balance(service.chain_data.multisig) | |||
There was a problem hiding this comment.
Also we were sending funds to the wrong safe
truemiller
approved these changes
Apr 11, 2024
angrybayblade
merged commit 705f37e
into
fix/handle-existing-deployments
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.