Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unwanted border props #597

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mohandast52
Copy link
Collaborator

Proposed changes

  • Removing the borders prop—noticed a glitch and will address it later using a CSS-only approach.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@@ -72,7 +48,7 @@ export const Main = () => {
<SwitchAgentSection />
<MainHeader />
<AlertSections />
<MainOlasBalance isBorderTopVisible={!hideMainOlasBalanceTopBorder} />
<MainOlasBalance />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we’ll try to come up with a CSS-only approach instead, if possible.

@mohandast52 mohandast52 marked this pull request as ready for review December 16, 2024 14:48
@mohandast52 mohandast52 merged commit b1678a3 into fix/meme-staging Dec 16, 2024
4 of 5 checks passed
@mohandast52 mohandast52 deleted the mohan/remove-unwanted-border-check branch December 16, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants