feat: support additional tokens required for initial funding #620
Conversation
Tanya-atatakai
force-pushed
the
feature/modius
branch
from
74e3d5e to
044b3bb
Compare
Tanya-atatakai
force-pushed
the
tanya/needs-funds-update
branch
from
f206d24 to
5f51bb5
Compare
| @@ -13,6 +13,7 @@ const schema = { | |||
| lastSelectedAgentType: { type: 'string', default: 'trader' }, | |||
| isInitialFunded_trader: { type: 'boolean', default: false }, | |||
| isInitialFunded_memeooorr: { type: 'boolean', default: false }, | |||
| isInitialFunded_modius: { type: 'boolean', default: false }, | |||
There was a problem hiding this comment.
ah we didn't discuss it 🫠 still afraid of that with your approach if we need to update e.g. trader.isInitialFunded, we'll need to update the whole object:
electronApi.store?.set?.(trader, {...electronApi.store?.get('trader'), isInitialFunded: true});
imagine somewhere at the same time we update e.g. firstRewardsNotificationShown, so we may loose previous update... but maybe that's impossible?
frontend/components/MainPage/sections/AlertSections/LowFunds/FundsToActivate.tsx
Outdated
Show resolved
Hide resolved
| @@ -14,7 +13,7 @@ export const AlertSections = () => { | |||
| <CardSection vertical> | |||
| <UpdateAvailableAlert /> | |||
| {isBackupViaSafeEnabled && <AddBackupWalletAlert />} | |||
| <NewStakingProgramAlert /> | |||
| {/* <NewStakingProgramAlert /> */} | |||
There was a problem hiding this comment.
If we are hiding just for "modius" should we put it behind the feature flag?
There was a problem hiding this comment.
it's not for modius, we just agreed it doesn't work properly at all... https://valory-workspace.slack.com/archives/C07GH5D26UB/p1733992345003699
| // !isActiveStakingProgramLoaded || | ||
| // activeStakingProgramId !== StakingProgramId.OptimusAlpha | ||
| // ) | ||
| // return null; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
can we keep this for "trader" and return null for other agents?
There was a problem hiding this comment.
in fact, this code means show the alert if activeStakingProgramId is Optimus (which is Modius), but for the rest return null. So, as I said in the previous comment, it's not working correctly...
…undsToActivate.tsx Co-authored-by: Mohan <[email protected]>
Proposed changes
add additional token requirements logic
All three tokens required
Funding ETH
Funding USDC
Funding OLAS (the button is enabled)
Debug info modal (probably not relevant anymore)
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply