Update agent, Windows patch #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoreira-valory
commented
Dec 20, 2024
Comment on lines
100
to
101
| # TODO: Patch for Windows failing hash (add -s). Revert once it's fixed on OpenAutonomy / OpenAEA | ||
| return self._run_cmd(args=[self._aea_bin, "-s", *args], cwd=cwd) |
There was a problem hiding this comment.
This should be reverted when the OpenAutonomy / Open AEA issue is resolved. cc @0xArdi @Adamantios @iasonrovis
There was a problem hiding this comment.
it might be required on other places as well, id suggest you do a search of other uses of the _aea_bin and add this flag everywhere.
There was a problem hiding this comment.
In principle everything should be run through _run_aea, shouldn't it?
There was a problem hiding this comment.
Addressed. Please re-review
0xArdi
approved these changes
Dec 20, 2024
0xArdi
approved these changes
Dec 20, 2024
dvilelaf
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update agent, Windows patch
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply