feat: support funds by chain #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
commented
Dec 26, 2024
| walletBalanceResult.evmChainId === selectedAgentConfig.evmHomeChainId, | ||
| )?.balance; | ||
|
|
||
| const isInitialFunded = storeState?.[selectedAgentType]?.isInitialFunded; | ||
| if (service && isInitialFunded && isServiceStaked) { |
There was a problem hiding this comment.
@truemiller can you please look at this code and the " // SERVICE IS STAKED, AND STARTING AGAIN" section below and tell me if I'm right or not - it looks, that if a user runs the agent for the second time, the code will alway end up here, and no "threshold check" check will happen (to check if a user has enough gas for starting the agent)
also, here we check this: (serviceTotalStakedOlas ?? 0) >= requiredStakedOlas but if a user staked already, their total staked will be more than required anyway, what sense does this make?
Tanya-atatakai
commented
Dec 26, 2024
| @@ -13,7 +13,7 @@ import { StakingProgramMap } from '.'; | |||
| export const MODE_STAKING_PROGRAMS_CONTRACT_ADDRESSES: Record<string, Address> = | |||
| { | |||
| [StakingProgramId.OptimusAlpha]: | |||
| '0x534c0a05b6d4d28d5f3630d6d74857b253cf8332', | |||
| '0x5fc25f50E96857373C64dC0eDb1AbCBEd4587e91', | |||
There was a problem hiding this comment.
this was pointing to wrong Modius alpha, updated to the right one
Tanya-atatakai
requested review from
truemiller and
OjusWiZard
and removed request for
mohandast52
OjusWiZard
reviewed
Dec 26, 2024
OjusWiZard
reviewed
Dec 26, 2024
Tanya-atatakai
force-pushed
the
tanya/modius-transfer
branch
from
08a0ff5 to
ef38a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply