Fix: Funding job to send amount upto the topup #637
Conversation
Signed-off-by: OjusWiZard <[email protected]>
| if asset_address == ZERO_ADDRESS: | ||
| # also count the balance of the wrapped native asset | ||
| safe_balance += get_asset_balance( | ||
| ledger_api=ledger_api, | ||
| contract_address=WRAPPED_NATIVE_ASSET.get(chain, asset_address), | ||
| address=chain_data.multisig, | ||
| ) |
There was a problem hiding this comment.
Why is this approach not taken into account also for the agent?
There was a problem hiding this comment.
Because in the case of Agent EOA, the agent doesn't swap xDAI for wxDAI and we don't want to it to happen that someone send wxDAI to the Agent EOA and the funding job no long funds xDAI in it, failing the agent to make transactions anymore.
There was a problem hiding this comment.
Seems quite custom logic, but ok.
| @@ -1491,19 +1491,25 @@ def fund_service_single_chain( # pylint: disable=too-many-arguments,too-many-lo | |||
| address=key.address, | |||
| ) | |||
| self.logger.info( | |||
| f"Agent {key.address} Asset: {asset_address} balance: {agent_balance}" | |||
| f"[FUNDING_JOB] Agent {key.address} Asset: {asset_address} balance: {agent_balance}" | |||
| ) | |||
| if agent_fund_threshold > 0: | |||
There was a problem hiding this comment.
Why is this check not performed in safe as well?
There was a problem hiding this comment.
I don't really see why we have this check. agent_fund_threshold will always be passed as positive without any programming error
There was a problem hiding this comment.
Me neither. Assuming the template has nonnegative values for the fund requirement, if we set, e.g. 0 fund requirements for USDC, then the condition agent_balance < agent_fund_threshold will not be triggered anyways...
Proposed changes
[FUNDING_JOB]tagged logs in the funding jobTypes of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply