Feat: stop trading conditions #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoreira-valory
commented
Apr 10, 2024
jmoreira-valory
commented
Apr 10, 2024
jmoreira-valory
commented
Apr 10, 2024
jmoreira-valory
commented
Apr 10, 2024
Adamantios
requested changes
Apr 11, 2024
Adamantios
reviewed
Apr 12, 2024
Adamantios
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for stop trading conditions.
The trader will stop trading and transit to RedeemRound if any of these conditions occur:
DISABLE_TRADINGis set totrue.This PR requires to reactor the staking_abci Skill to extract common functionality to be used in the check_stop_trading_abci.
This PR contains a small hack to solve an issue with non-initialized data. Namely, it always requires that the trader don't skip going to the "trading path" on the first period. See detailed comment.