Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ new staking support #264

Merged
merged 30 commits into from
Jun 19, 2024
Merged

Feat/ new staking support #264

merged 30 commits into from
Jun 19, 2024

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented May 31, 2024

This PR adds support for the new (service) staking contract.

@jmoreira-valory
Copy link
Collaborator

This branch should address #280

Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you run this with a staked service to verify that it works?

packages/valory/services/trader_omen_gnosis/service.yaml Outdated Show resolved Hide resolved
Comment on lines +44 to +51
class StakingState(Enum):
"""Staking state enumeration for the staking."""

UNSTAKED = 0
STAKED = 1
EVICTED = 2


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adamantios Reverted as discussed

@jmoreira-valory
Copy link
Collaborator

Looks good. Did you run this with a staked service to verify that it works?

Yes.

@Adamantios Adamantios merged commit fd6c3a1 into main Jun 19, 2024
18 checks passed
@Adamantios Adamantios deleted the feat/new-staking branch June 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants