Avoid dlp validator crashes eg if rpc goes down #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
volod-vana
commented
Jul 11, 2024
volod-vana
commented
tnunamak
reviewed
Jul 11, 2024
| @@ -252,13 +275,21 @@ def get_current_block(self) -> int: | |||
| Knowing the current block number is essential for querying real-time data and performing time-sensitive | |||
| operations on the blockchain. It serves as a reference point for network activities and data synchronization. | |||
| """ | |||
| return self.web3.eth.block_number | |||
| return self.circuit_breaker.call(self._get_current_block) | |||
There was a problem hiding this comment.
Could this be used at a higher level, e.g. where the server is spawned?
Kahtaf
reviewed
Jul 11, 2024
| @@ -84,6 +84,27 @@ def __init__( | |||
| if sync: | |||
| self.sync(block=None, lite=lite) | |||
|
|
|||
| self.cache_file = f"state_cache_{network}_{dlp_uid}.json" | |||
|
|
|||
| def save_cache(self): | |||
There was a problem hiding this comment.
What's the difference between the cache and the state file? Seems to be saving the same data?
| def check_rpc_health(self): | ||
| try: | ||
| block_number = self.get_current_block() | ||
| vana.logging.info(f"RPC is healthy. Current block number: {block_number}") |
There was a problem hiding this comment.
Can we remove this, I feel this may get too noisy in the logs.
| @@ -252,13 +275,21 @@ def get_current_block(self) -> int: | |||
| Knowing the current block number is essential for querying real-time data and performing time-sensitive | |||
| operations on the blockchain. It serves as a reference point for network activities and data synchronization. | |||
| """ | |||
| return self.web3.eth.block_number | |||
| return self.circuit_breaker.call(self._get_current_block) | |||
There was a problem hiding this comment.
I'm probably misunderstanding, but does the circuit breaker give us anything additional that the @Retry doesn't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.