Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse encoders for ordinal variables [type:bug] #251

Closed
wants to merge 1 commit into from

Conversation

bvanbreugel
Copy link
Contributor

@bvanbreugel bvanbreugel commented Jan 26, 2024

Description

Fixes #250 (comment)

Notes

  • Only quick fix. Sklearn recommends against using LabelEncoder for features, I have not changed this.
  • Results in error when there are unknown feature classes in e.g. X_syn (compared to X_gt). This is safer, though does mean we cannot evaluate easily on a very small real dataset. If we want to avoid this, we could use OrdinalEncoder instead, which allows ignore_unknown argument to be passed

Checklist

@robsdavis
Copy link
Contributor

Thanks for having a look at this issue, Boris. But as you said you don't have time to get these tests passing. I am closing this PR and not merging. I will leave the related issue open and will review it when I get a chance.

@robsdavis robsdavis closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eval does not share encoding transformers
2 participants