Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of Pytorch 2x, Pandas 2x, and Numpy 1.26 #269

Closed
wants to merge 24 commits into from

Conversation

bvanbreugel
Copy link
Contributor

@bvanbreugel bvanbreugel commented Apr 11, 2024

Description

Allow installing Pytorch 2 and pandas 2. This solves four open issues #172, #171, #234 #245

Affected Dependencies

Only removed restrictions on pytorch, numpy, and pandas versions

How has this been tested?

Ran standard workflows

Checklist

@bvanbreugel bvanbreugel marked this pull request as draft April 11, 2024 13:22
@bvanbreugel bvanbreugel changed the title Bump to Pytorch2 Allow use of Pytorch 2x, Pandas 2x, and Numpy 1.26 Apr 11, 2024
@bvanbreugel
Copy link
Contributor Author

The problem of upgrading to Torch 2.x arises from the DP mechanism in CTGAN, and seems to be the Opacus library itself being incompatible. I don't know yet how to fix this---if anyone wants to contribute to this, please reach out.

@cynddl
Copy link

cynddl commented May 26, 2024

Thanks @bvanbreugel for opening this PR. We have been trying to use synthcity in our research, but the complex dependencies with old versions of PyTorch and Python is a nightmare. That's a shame.

Have you been able to make it work? Opacus 1.4 works with PyTorch 2.0 apparently.

@boegel
Copy link

boegel commented Jul 31, 2024

Any updates on this?

We're also very interested to let synthcity support PyTorch 2.x

@robsdavis
Copy link
Contributor

The dependency requirements have now been updated in #288

@robsdavis robsdavis closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants