Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite: add vite v6 to peer Dependencies #1508

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nilsingwersen
Copy link

No description provided.

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 74cf0fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
Copy link
Contributor

LekoArts commented Dec 4, 2024

Since I've ran into withastro/astro#12614 I think there will be more work necessary for vanilla-extract to be compatible with Vite 6 than just updating the peer dependencies.

@SimenB
Copy link
Contributor

SimenB commented Dec 5, 2024

This won't be enough as long as the plugin depends on @vanilla-extract/integration, which has these deps:

"vite": "^5.0.11",
"vite-node": "^1.2.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants