Merge build options from viteConfig in compiler #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2903b3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to update Remix's use of @vanilla-extract/integration (which is still at v6) and came across how the new compiler package now inlines small files into the resulting CSS. These dataurl strings broke the Remix integration tests, so I figured it was better to match the prior behavior.
To match the prior behavior, I need to pass the option
viteConfig.build.assetsInlineLimit: 0into the compiler, but thebuildoptions were being ignored because the compiler is setting one of them.So this patch is the minimum to get the option passed. I see that there have been earlier efforts to do a deep merge on the options (at least for the Vite plugin), but this is more narrow and is for the compiler.