Implement enableDevCache option in Vite plugin
#1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements an `enableDevCache` option in the Vite plugin which helps alleviate dev server performance issues in large projects caused by redundant `.vanilla.css` file loading
🦋 Changeset detectedLatest commit: c246505 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open
2 tasks
hartz89
commented
May 20, 2025
| @@ -217,9 +266,10 @@ export function vanillaExtractPlugin({ | |||
| } | |||
|
|
|||
| for (const file of watchFiles) { | |||
| const normalizedFilePath = normalizePath(file); | |||
There was a problem hiding this comment.
I wasn't sure if I should put the invalidation check before or after the "add watch file" block, or how these blocks might affect one another. Let me know if you have thoughts.
hartz89
commented
May 21, 2025
| return true; | ||
| } | ||
|
|
||
| const hash = await getFileHash(moduleId); |
There was a problem hiding this comment.
Is the hashing step just a waste of CPU time? Should we just use the file contents as the values of the map? Hashing CPU time is a trade-off for cache memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1488
This PR implements an
enableDevCacheoption in@vanilla-extract/vite-pluginwhich helps alleviate dev server performance issues in large projects caused by redundant.vanilla.cssfile loading.I made this an option rather than a default because there is an obvious trade-off here: adding these filesystem and hashing operations incurs cost, so the default /
falsesetting is likely faster in small projects. But in large projects, this seems worthwhile.It cut my cold start load times by about 25%. I think the performance improvement would've been bigger if I hadn't already added sprinkles and recipes runtime imports to
optimizeDeps.include- they were causing some HMR churn on startup so it made the duplicate imports more costly.