Add new strings for new discussion thread extras #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhovhannes
changed the title
s-francis
requested changes
Dec 5, 2024
tx-source/site_core.php
Outdated
Comment on lines
2507
to
2512
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
can we have this extra lines removed
| @@ -484,6 +484,7 @@ | |||
| $Definition['Connect your profile to social networks.'] = 'Connect your profile to social networks to share activity with your friends and followers.'; | |||
| $Definition['Contact Us'] = 'Contact Us'; | |||
| $Definition['Content'] = 'Content'; | |||
| $Definition['Content from Ignored User.'] = 'Content from Ignored User.'; | |||
There was a problem hiding this comment.
why is "from" small cased? should it be "From"?
There was a problem hiding this comment.
This is correct per Sarah's feedback, see the article https://prowritingaid.com/list-of-words-not-capitalized-in-titles . The rest is addressed.
tx-source/site_core.php
Outdated
| @@ -1799,6 +1804,7 @@ | |||
| $Definition['Subscriber'] = 'Subscriber'; | |||
| $Definition['Success'] = 'Success'; | |||
| $Definition['Success!'] = 'Success!'; | |||
| $Definition['Success! User has been warned.'] = 'Success! User has been warned.'; | |||
tx-source/site_core.php
Outdated
| $Definition["You don't have the close permission on the following discussions:"] = "You don't have the close permission on the following discussions:"; | ||
| $Definition["You don't have the delete permission on the following discussions:"] = "You don't have the delete permission on the following discussions:"; | ||
| $Definition["You don't have required permission to warn selected comments."] = "You don't have required permission to warn selected comments."; | ||
| $Definition["Only one user may be warned at a time. Make sure all selected comments are from the same user to proceed with bulk warning."] = "Only one user may be warned at a time. Make sure all selected comments are from the same user to proceed with bulk warning."; |
There was a problem hiding this comment.
I think this should be split as well into two different definitions
tx-source/site_core.php
Outdated
| $Definition["View New Post"] = "View New Post"; | ||
| $Definition["Posts have been deleted."] = "Posts have been deleted."; | ||
| $Definition["Delete Posts"] = "Delete Posts"; | ||
| $Definition["You are about to delete <0/> posts. These posts will remain in the change log. Are you sure you want to continue?"] = "You are about to delete <0/> posts. These posts will remain in the change log. Are you sure you want to continue?"; |
There was a problem hiding this comment.
This should split as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PRs
https://github.com/vanilla/vanilla-cloud/pull/8411
https://github.com/vanilla/vanilla-cloud/pull/8468
https://github.com/vanilla/vanilla-cloud/pull/8458
https://github.com/vanilla/vanilla-cloud/pull/8493
https://github.com/vanilla/vanilla-cloud/pull/8531