Update weaviate_vector.py #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bedrock was not working because the client was not recognised, so getting a value error. After adding client now its giving the response we need.
|
@zainhoda Kindly do the review |
andreped
suggested changes
Sep 25, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| class WeaviateDatabase(VannaBase): | |||
|
|
|||
| def __init__(self, config=None): | |||
| def __init__(self, config=None,client= None): | |||
There was a problem hiding this comment.
If you want to set the client directly, you should aim to do something like that is done for Chroma.
See here:
https://github.com/vanna-ai/vanna/blob/main/src/vanna/chromadb/chromadb_vector.py#L23
and here:
https://github.com/vanna-ai/vanna/blob/main/src/vanna/chromadb/chromadb_vector.py#L38
So basically, pass the client as part of the config, and then you likely want to update what is done here, if the client is part of the config:
https://github.com/vanna-ai/vanna/pull/654/files#diff-acb7ec3a110767dae2ec2a321b040ea390d7165a898d49c6ce310180ece936daR39
See the chroma client implementation for inspiration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bedrock was not working because the client was not recognised, so getting a value error. After adding client now its giving the response we need.