fix issue with javadocJar tasks #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
commented
May 25, 2024
Comment on lines
-156
to
-159
| // TODO: https://youtrack.jetbrains.com/issue/KT-46466 https://github.com/gradle/gradle/issues/26091 | ||
| project.tasks.withType(AbstractPublishToMaven::class.java).configureEach { publishTask -> | ||
| publishTask.dependsOn(project.tasks.withType(Sign::class.java)) | ||
| } |
There was a problem hiding this comment.
This was just fixing the issue for the signing task but not for the publish and metadata tasks.
gabrielittner
commented
May 25, 2024
| "${prefix}EmptyJavadocJar", | ||
| JavadocJar::class.java, | ||
| ) { | ||
| it.archiveBaseName.set("$prefix-javadoc") |
There was a problem hiding this comment.
Need to set this so that the output has different names per publication, this is just the local file name and doesn't influence how it is published.
vanniktech
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a separate javadocJar task per publication. This avoids an issue where Gradle gets confused and thinks the publish task, metadata task or sign task of one publication has an implicit dependency on the task. While this means there is a bit of additional work, zipping should generally be fast and the javadoc (or dokka) generation itself is still just run once.