Version 0.4.0 #8
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 11 27 +16
Lines 517 614 +97
=====================================
- Misses 517 614 +97
|
| // Created by Francesco Paolo Severino on 30/06/24. | ||
| // | ||
|
|
||
| public enum OrdersError: Error { |
There was a problem hiding this comment.
Before you release the major version this should be hidden behind a struct as in https://github.com/vapor/jwt-kit/blob/main/Sources/JWTKit/JWTError.swift IMO as adding/removing cases to this (which is likely) is source breaking and requires a new major release
| } | ||
|
|
||
| /// The type of transit for a boarding pass. | ||
| public enum TransitType: String, Encodable { |
| } | ||
|
|
||
| /// The format of the barcode. | ||
| public enum BarcodeFormat: String, Encodable { |
| import Foundation | ||
|
|
||
| public enum PassKitError: Error { | ||
| public enum PassesError: Error { |
| var _$order: Parent<OrderType> { | ||
| guard let mirror = Mirror(reflecting: self).descendant("_order"), | ||
| let order = mirror as? Parent<OrderType> else { | ||
| fatalError("order property must be declared using @Parent") |
There was a problem hiding this comment.
Not a big fan of these fatalErrors honestly
There was a problem hiding this comment.
What could I replace them with? In most cases I cannot make these properties optional
There was a problem hiding this comment.
Throwing custom Errors which can be caught (and debugged) and don't just crash the app
Thanks for the feedback Paul! |
PKErrorLogmodel, where thecreated_atFieldKeydidn't coincide in the model and in the migration.authenticationTokenunique for each pass, as requested by the Wallet documentation, improving security.PassKitfor the types shared between thePassesand the upcomingOrdersmodules.PassJSONprotocol to help build thepass.json.Orderstarget.