Update to Swift 5.9 #134
Update to Swift 5.9 #134
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 82.09% 82.34% +0.24%
==========================================
Files 25 25
Lines 2603 2617 +14
==========================================
+ Hits 2137 2155 +18
+ Misses 466 462 -4
|
Package.swift
Outdated
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.4 | |||
| // swift-tools-version:5.8 | |||
There was a problem hiding this comment.
The Docs.docc problem is solved with any version higher than 5.4, I put 5.8 only because vapor/leaf is on 5.8
There was a problem hiding this comment.
The correct minimum to use at this point in time is 5.9.
There was a problem hiding this comment.
Ideally you would also enable various Swift settings (most especially strict concurrency), but that would likely entail a good bit of work to clear up Sendable issues.
There was a problem hiding this comment.
Ok, I have added the common 5.9 Swift settings, the only one that required immediate changes is "ExistentialAny", strict concurrency just gives a bunch of warnings.
Should we keep the setting and warnings or should I disable it for now?
There was a problem hiding this comment.
This PR could be revisited
There was a problem hiding this comment.
Keep the warnings for now (they shouldn't appear in adopters packages I don't think) and then we can follow up with #125
fpseverino
changed the title
NIOLock deprecation warnings
These changes are now available in 1.12.0
swift-tools-versionto 5.9swiftSettingsto targetsTemplatesfolder in test target; added to target's resourcesDocs.doccfolder in main target; updatingswift-tools-versionfixes itLockwas deprecated in favour ofNIOLock