Update for new SQLKit and support more URL string formats #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialAny and StrictConcurrency compliance
…ths from the encoder and decoder, add more features to the dialect, improve NULL handling, other misc cleanup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 60.85% 66.04% +5.18%
==========================================
Files 8 9 +1
Lines 281 321 +40
==========================================
+ Hits 171 212 +41
+ Misses 110 109 -1
|
MahdiBM
approved these changes
Apr 28, 2024
gwynne
force-pushed
the
update-for-new-sqlkit
branch
from
f6ea2d2
to
452f20f
Compare
0xTim
approved these changes
Apr 29, 2024
| let json: JSONDecoder | ||
|
|
||
| /// The `JSONDecoder` used for decoding values that can't be directly converted. | ||
| let json: FakeSendable<JSONDecoder> |
There was a problem hiding this comment.
We could just @preconcurrency import Foundation on Linux instead
There was a problem hiding this comment.
That triggers a whole different mess of warnings, since Sendability on macOS isn't available before macOS 13.0. This is actually much easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.8.0
Adds support for several additional
mysql:URL formats, following in the footsteps of similar support in PostgresKit. Also takes advantage of the recent updates to SQLKit, bumps minimum Swift version to 5.8, and does some general cleanup.Details on new URL formats can be found in the MySQLKit API documentation.