Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bindings with optional values in PostgresBindings #520

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rgcottrell
Copy link
Contributor

This adds additional methods to PostgresBindings to allow bindings to be created with optionals. The new methods either append a null or delegate to original non optional version of the method. This will make it easier to create PostgresPreparedStatements insert into or update tables with nullable columns. See Issue #509.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 61.77%. Comparing base (225c5c4) to head (b3286e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/PostgresNIO/New/PostgresQuery.swift 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   60.23%   61.77%   +1.54%     
==========================================
  Files         125      125              
  Lines        9191    10070     +879     
==========================================
+ Hits         5536     6221     +685     
- Misses       3655     3849     +194     
Files with missing lines Coverage Δ
Sources/PostgresNIO/New/PostgresQuery.swift 69.32% <0.00%> (-11.45%) ⬇️

... and 74 files with indirect coverage changes

Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great patch! Thank you!

@fabianfett fabianfett merged commit d4c2f38 into vapor:main Oct 21, 2024
9 checks passed
@fabianfett fabianfett added the semver-minor Adds new public API. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants