-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The file status icon on tabs is not clear #100
Comments
My recommendation would be: |
My question is more simple, what is the purpose of that option? |
It is supposed to work like this:
|
Oh so 'red' is related to new search results? that seemed not intuitive to me... Red seems like a highlight to me, meaning there is something new (new lines, not necessarily search-related). Maybe it would work better with different kinds of highlights... For example 'blue eject' for new lines, and 'red eject' for new lines matching the auto-refresh search. That would be more intuitive to me. Also I was confused by the 'eject' icon because it looked very much like the 'Follow file' icon (but you changed the Follow file recently so...) |
Made this icon to be 'blue eject' for new lines, and 'red eject' for new lines matching the auto-refresh search from build 483 |
thanks, i will check that |
The blue/red eject should disappear once the tab is activated, as an acknowledgement that the user has seen this notification icon. If the file is already the active tab, there should be a way to reset this "new lines" status icon aswell, otherwise the 'eject' icon will stay forever. Maybe on any action (click, wheel, keyboard) in the window ? |
Eject icon should already disappear on scrolling and some mouse clicks (maybe inside the window with search results). I think the original Nick's idea behind it was to remove the icon once user scrolled to new data, but I'm not sure. I'll try to add more user interaction events to remove it and see how it goes. |
It disappear on scrolling, right. Then please make it disappear also when the user switch to that tab (and the view is already at the end - because of follow mode) |
As far as I can observe, that tab indicator is still not satisfying to me... I want to be able to see at a glance in which tabs there are new lines. Tab indicator without new lines should be uncolored ≡ as to not attract the eyes. |
Made icon switch to ≡ when entering tab with changes and follow mode is enabled in 19.12.0.554. |
That's a good first step. Thanks! |
Mmh does not always work, it seems.. I have a follow-mode tab that refuse to reset to ≡. Even when I force a scroll down with the mouse. |
and apparently, the icon does not always turn to blue arrow when there is new lines either.. |
I noticed another issue which might be related, when tabs are rearranged (via DND) the indicator displays on the tab matching the index where the file was originally, not where it is now. If this is unrelated I can open a separate issue. |
I don't understand the behavior of that little fellow icon after the file name in the tab header.
Some times it's ≡, sometimes it's an "eject down" icon that looks like the one from the "follow file" button, sometimes this "eject down" icon is red.
However I haven't found any link with the actual "follow mode" of the file, or even as an indicator that there as been new lines added since I last viewed this tab..
I don't know if it's buggy or just an explanation is required.
BTW, the 'Wiki' link on top of this github repo doesn't seem to work.
The text was updated successfully, but these errors were encountered: