Add test for view "Helper" module to improve coverage #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgestrand
reviewed
Jul 17, 2023
Comment on lines
+220
to
+225
| include Pundit::Authorization | ||
| include Pundit::Helper | ||
| # Mark protected methods public so they may be called in test | ||
| # rubocop:disable Style/AccessModifierDeclarations | ||
| public(*Pundit::Authorization.private_instance_methods) | ||
| # rubocop:enable Style/AccessModifierDeclarations |
There was a problem hiding this comment.
Hi! Sorry about coming in this late.
I don't think we need to make any private instance methods public at all? Also the comment refers to protected methods but this does private methods.
What about this?
Suggested change
| include Pundit::Authorization | |
| include Pundit::Helper | |
| # Mark protected methods public so they may be called in test | |
| # rubocop:disable Style/AccessModifierDeclarations | |
| public(*Pundit::Authorization.private_instance_methods) | |
| # rubocop:enable Style/AccessModifierDeclarations | |
| def self.helper(mod) | |
| include(mod) | |
| end | |
| include Pundit::Authorization |
Burgestrand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thank you for the great Gem!
I often use this gem!
Added
Helper.policy_scopetest to improve maintainability.As a result, the test coverage changed from 98.41% to 100% in
lib/pundit.rbIf there is a place to fix, please let me know.
best regards.