Fix: Pundit.authorize when passing a custom cache
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgestrand
force-pushed
the
kbs/fix-pundit-authorize-cache-parameter
branch
3 times, most recently
from
9bfbe4c
to
474b0b6
Compare
Burgestrand
force-pushed
the
kbs/code-janitoring
branch
2 times, most recently
from
ba324e4
to
e296e83
Compare
Burgestrand
force-pushed
the
kbs/fix-pundit-authorize-cache-parameter
branch
from
474b0b6
to
7eb7a46
Compare
We accidentally broke this interface when the internal cache interface changed in aedc862. According to documentation, and how it worked in the past, it should accept a Hash-like interface.
Burgestrand
force-pushed
the
kbs/fix-pundit-authorize-cache-parameter
branch
from
7eb7a46
to
c620716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally broke this interface when the internal cache interface changed a while back.
To do
PS: Thank you for contributing to Pundit ❤️