Header length verification correction #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
|
Unfortunately, this fix is wrong. According to Qemu source and indeed QCOW2 specification (although not very explicit, but it is evident when reading on that header extensions are not part of the header struct) the header_length do not include the extensions. The fundamental problem is that the qcow2 crate does not handle "additional fields" at all. This is easily fixed. I will soon submit a pull request to fix this properly for review. |
|
I was indeed a bit doubtful -- thanks for digging deeper @niklasha 👍 |
|
Thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been noticed in vasi/qcow2-fuse#4.
The fix seems to alleviate the problem.
This is a cool and useful project! Please respond 🍰☺️