Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #117

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Update README #117

merged 2 commits into from
Nov 13, 2023

Conversation

cmangla
Copy link
Contributor

@cmangla cmangla commented Nov 9, 2023

More details for macOS build example.

Needed these days because squashfuse is not available in upstream homebrew core anymore.

@cmangla
Update README
22208dd 
More details for macOS build example
@vasi
Copy link
Owner

vasi commented Nov 9, 2023

Hmm, installing in $HOME/.local sounds pretty weird tbh. How about a placeholder like /path/where/to/install or something? Or is there a "normal place" is macOS where a user would install things?

@cmangla
Copy link
Contributor Author

cmangla commented Nov 9, 2023

You're right. A more normal place is probably /usr/local/, even on macOS. Feel free to update this PR as you wish, or I can do it tomorrow.

@cmangla
Copy link
Contributor Author

cmangla commented Nov 10, 2023

I changed it to /usr/local/. @vasi

vasi
vasi approved these changes Nov 13, 2023
View reviewed changes
Copy link
Owner

@vasi vasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We could likely also get rid of all the autotools steps too, and replace with just ./autogen.sh, but I don't have a convenient Mac for testing at the moment.

@vasi vasi merged commit 200ba3d into vasi:master Nov 13, 2023
7 checks passed
@cmangla cmangla mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasi vasi vasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmangla @vasi