Fix module path from ddelnano to vatesfr #302
Conversation
belfhi
changed the title
|
@ddelnano please run CI :) |
go.mod
Outdated
| go 1.20 | ||
| go 1.22 | ||
|
|
||
| toolchain go1.22.0 |
There was a problem hiding this comment.
If upgrading the go version is required, it should be separated out into a different change. The github.com/hashicorp/terraform-plugin-sdk project is still on go 1.21, so I don't think we should upgrade to go 1.22 unless there is a strong need.
There was a problem hiding this comment.
This also requires Jenkins side changes to upgrade the go version.
.github/workflows/tfplugindocs.yml
Outdated
| go-version: "1.20" | ||
| go-version: "1.22" |
There was a problem hiding this comment.
Same comment here and for the other GitHub action jobs.
client/go.mod
Outdated
| module github.com/ddelnano/terraform-provider-xenorchestra/client | ||
|
|
||
| go 1.20 | ||
|
|
||
| require ( | ||
| github.com/cenkalti/backoff/v3 v3.2.2 | ||
| github.com/gorilla/websocket v1.4.2 | ||
| github.com/mitchellh/mapstructure v1.5.0 | ||
| github.com/sourcegraph/jsonrpc2 v0.0.0-20210201082850-366fbb520750 | ||
| ) |
There was a problem hiding this comment.
What's the rationale for removing this? This was done to support terraformer (#138) and there is also a strong likelihood that this code will be shared by the XO packer plugin.
The terraformer integration is not important, but the XO packer plugin will need this exact same code and the plan is to have this live outside of this repository.
There was a problem hiding this comment.
well we had import errors when we built the pulumi provider that we could resolve by just having one go.md file.
I see the need for it now, but maybe moving it into another repository is the way to go then :)
There was a problem hiding this comment.
Can you share the steps for reproducing the pulumi build issue or share the output of building it against #309? Unless it it isn't possible to make the pulumi work coexist, this must stay for now.
There was a problem hiding this comment.
@belfhi just checking in on my earlier message. Once that is answered, we can move quickly on merging the last PR.
There was a problem hiding this comment.
hi @ddelnano so I can confirm that removing the client go.mod is not neccessary. I manages to build the pulumi provider https://github.com/belfhi/pulumi-xenorchestra using a rewrite for the revision.
|
|
||
| # Updating the VM to use 3 CPUs would happen without stopping/starting the VM |
There was a problem hiding this comment.
This is cause the failing tfplugindocs run since it removed the same whitespace from the vm resource mardown file.
ddelnano@ddelnano-desktop:~/code/terraform-provider-xenorchestra (belfhi/master) $ ~/go/bin/tfplugindocs
ddelnano@ddelnano-desktop:~/code/terraform-provider-xenorchestra (belfhi/master) $ git diff docs/
diff --git a/docs/resources/vm.md b/docs/resources/vm.md
index e979d35..7972c31 100644
--- a/docs/resources/vm.md
+++ b/docs/resources/vm.md
@@ -129,7 +129,7 @@ $ xo-cli xo.getAllObjects filter='json:{"id": "cf7b5d7d-3cd5-6b7c-5025-5c935c8cd
"max": 4,
"number": 2
}
-
+
# Updating the VM to use 3 CPUs would happen without stopping/starting the VM
# Updating the VM to use 5 CPUs would stop/start the VM
Please run go generate ./... from the root of the repo to make those changes locally.
|
@belfhi I've pulled out the go upgrade commit into #307 and will merge that once the jenkins build passes. I did not remove the |
belfhi
changed the title
#298 (comment)