feat(xo-web/disks): allow user to delete snapshots before migrating VDI #7903
Conversation
| @@ -107,7 +107,7 @@ set.resolve = { | |||
|
|
|||
| // ------------------------------------------------------------------- | |||
|
|
|||
| export async function migrate({ vdi, sr, resourceSet }) { | |||
| export async function migrate({ vdi, sr, removeSnapshotsBeforeMigrating, resourceSet }) { | |||
There was a problem hiding this comment.
removeSnapshotsBeforeMigrating → destroySnapshots.
| const vdi = this.getObject(vdiRef) | ||
| for (const vbdRef of vdi.VBDs) { | ||
| const vbd = this.getObject(vbdRef) | ||
| await this.VM_destroy(vbd.VM) |
There was a problem hiding this comment.
Do not destroy VMs when migrating a VDI!
There was a problem hiding this comment.
Sorry I should have commented the code because indeed it's not very clear like this.
So when testing with @MathieuRA we realised that vdi.snapshots returns the VDI snapshots instead of the actual VM snapshots so we have to go through their VBDs to actually destroy the snapshots
There was a problem hiding this comment.
The issue is about migrating VDI, not VM, and therefore destroying all its snapshot.
We are not talking about destroying VM snapshots here, that's a possibility but that's not the original request.
There was a problem hiding this comment.
Either:
- we destroy only VDI snapshots (detaching it from any existing VMs)
- we destroy the VDI snapshots and all VMs which contains them
In either case, this should be obvious in the API and the UI.
There was a problem hiding this comment.
I don't think there's any sense to keep some VM snapshots alone without their VDIs. Since we decided to migrate the VM original VDI, we have a binary choice:
- leaving XAPI moving the entire chain to the new SR
- removing all the VM snapshots (with their VDIs) before migrating to avoid a far longer migration process
Most of the time, there's one disk per VM, but maybe 2 or 3 VM.snapshot. Since delta won't work as soon as we move the VM VDI to a new SR, most of the time, removing all VM.snapshots make sense (and when it's not, the user can make a choice)
There was a problem hiding this comment.
We could add a second toggle to allow the user to also destroy the VDIs snapshots?
I pinged @AtaxyaNetwork on mattermost about this and i'm waiting for some clarifications on what she meant by "remove snapshots"
Description
Fixes #7275
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md