Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup xo task #7963

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Backup xo task #7963

wants to merge 4 commits into from

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Sep 5, 2024

Description

Replacing backup tasks by XO tasks.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

b-Nollet
b-Nollet commented Sep 5, 2024
View reviewed changes
@xen-orchestra/backups/_runners/VmsRemote.mjs Outdated
@@ -114,6 +114,7 @@ export const VmsRemote = class RemoteVmsBackupRunner extends Abstract {
.run(async () => {
try {
const result = await vmBackup.run()
// TODO : handle next line
task.success(result)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-f I don't really know how to handle this part with XO tasks, I have not found a similar method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly how it works or why we did this, but I think we need to talk about this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can cheat to achieve this:

task.run(() => result)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I suspect it will not work because the new implementation does not allow nested runs for the same task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-Nollet @julien-f