Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/rest-api/dashboard): add vmsProtection information #7964

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 5, 2024

Description

  • protected: The VM is included in at least one active job with a successful result in its last execution.
  • unprotected: The VM is in a job without an enabled schedule, or the VM is in an active job, but the last job execution was not successful.
  • notInJob: The VM is either not part of any job or has the xo:no-bak tag

  • VMs with xo:no-bak tag are always counted in notInJob (since they are not backed up)
  • VMs replications are not counted at all (this mean the sum of protected, unprotected and notInJob can be different from the total number of "VMs".
  • Backed-up VMs in a failed backup job are counted as protected.
  • For non smartMode backup, VMs that no longer exist in the infrastructure are not counted.

{
   ...
   backups: {
      ...
      vmsProtection: {
         protected: number,
         unprotected: number,
         notInJob: number
      }
   } | undefined
}

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Sep 5, 2024
@MathieuRA MathieuRA requested review from MelissaFrncJrg and fbeauchamp and removed request for MelissaFrncJrg September 5, 2024 08:11
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the rest-api-dashboard-vms-protection branch from eff846f to 46c4e62 Compare September 18, 2024 08:53
@julien-f julien-f removed their request for review September 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants