fix(xo-server,xo-web/SR/new): fix reattach button not displayed for HBA

CHANGELOG.unreleased.md

@@ -15,6 +15,8 @@
 
 > Users must be able to say: “I had this issue, happy to know it's fixed”
 
+- [SR/New] Fix reattach button not displayed for HBA (PR [#7986](https://github.com/vatesfr/xen-orchestra/pull/7986))
+
 ### Packages to release
 
 > When modifying a package, add it here with its release type.
@@ -33,5 +35,6 @@
 
 - @xen-orchestra/log minor
 - xo-server minor
+- xo-web patch
 
 <!--packages-end-->

packages/xo-server/src/api/sr.mjs

@@ -339,7 +339,7 @@ export async function createHba({ host, nameLabel, nameDescription, scsiId, srUu
       uuid: srUuid,
       nameLabel,
       nameDescription,
-      type: 'hba',
+      type: 'lvmohba', // SR LVM over HBA https://team.vates.fr/vates/pl/wuedob5cj3bfbmbzeyjjpnxpda
       deviceConfig,
     })
   }

packages/xo-web/src/xo-app/new/sr/index.js

@@ -281,22 +281,7 @@ export default class New extends Component {
           srUuid
         ),
       smb: () => createSrSmb(host.id, name.value, description.value, server.value, username.value, password.value),
-      hba: async () => {
-        if (srUuid === undefined) {
-          const previous = await probeSrHbaExists(host.id, scsiId)
-          if (previous && previous.length > 0) {
-            try {
-              await confirm({
-                title: _('existingLunModalTitle'),
-                body: <p>{_('existingLunModalText')}</p>,
-              })
-            } catch (error) {
-              return
-            }
-          }
-        }
-        return createSrHba(host.id, name.value, description.value, scsiId, srUuid)
-      },
+      hba: async () => createSrHba(host.id, name.value, description.value, scsiId, srUuid),
       iscsi: async () => {
         if (srUuid === undefined) {
           const previous = await probeSrIscsiExists(
@@ -415,6 +400,7 @@ export default class New extends Component {
 
   _handleSrHbaSelection = async scsiId => {
     this.setState({
+      existingSrs: await probeSrHbaExists(this.state.host.id, scsiId),
       scsiId,
       usage: true,
     })