Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(xo-collection): convert from Jest to node:test #7987

Merged
merged 12 commits into from
Sep 24, 2024
Merged

test(xo-collection): convert from Jest to node:test #7987

merged 12 commits into from
Sep 24, 2024

Conversation

velvetrevolver
Copy link
Contributor

@velvetrevolver velvetrevolver commented Sep 13, 2024 •
edited
Loading

Description

Convert unit tests of xo-collection from Jest to node-core-test

XO-175

For the review, I left the Jest tests on which the node:test tests are based. I will remove them in a commit.

Note:

  • Jest test are .spec.js
  • node:test tests are .test.js

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@velvetrevolver velvetrevolver self-assigned this Sep 13, 2024
@velvetrevolver velvetrevolver force-pushed the xo-collection-jest-to-node-core-test branch from a6ca927 to 6c174ac Compare September 13, 2024 14:02
julien-f
julien-f reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a conversion if you are not removing the old tests ;)

packages/xo-collection/src/collection.test.js Outdated Show resolved Hide resolved
packages/xo-collection/src/collection.test.js Outdated Show resolved Hide resolved
@julien-f
Copy link
Member

Please remove the old tests as it will make my review easier.

@velvetrevolver velvetrevolver force-pushed the xo-collection-jest-to-node-core-test branch 2 times, most recently from 1a8ea78 to b8e88f3 Compare September 20, 2024 11:23
@julien-f julien-f force-pushed the xo-collection-jest-to-node-core-test branch from 049c8b5 to 24cdfa7 Compare September 24, 2024 08:18
@julien-f julien-f force-pushed the xo-collection-jest-to-node-core-test branch from 24cdfa7 to 5026bfa Compare September 24, 2024 12:24
@julien-f julien-f force-pushed the xo-collection-jest-to-node-core-test branch from 5026bfa to 3a6ede9 Compare September 24, 2024 12:27
@julien-f julien-f force-pushed the xo-collection-jest-to-node-core-test branch from 11ba98f to d867112 Compare September 24, 2024 12:31
@julien-f julien-f changed the title chore: convert unit tests of xo-collection from Jest to node-core-test test(xo-collection): convert from Jest to node:test Sep 24, 2024
@julien-f julien-f merged commit 206f595 into master Sep 24, 2024
1 check passed
@julien-f julien-f deleted the xo-collection-jest-to-node-core-test branch September 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

Assignees

@velvetrevolver velvetrevolver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@velvetrevolver @julien-f @stephane-m-dev