feat(backups): implement long term retention #7999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
changed the title
fbeauchamp
commented
Oct 18, 2024
| @@ -1,4 +1,86 @@ | |||
| const LTR_DEFINITIONS = { | |||
| daily: { | |||
| makeDateFormatter: ({ firstHourOfTheDay = 0 } = {}) => { | |||
There was a problem hiding this comment.
use the timezone of the backup
long term retention sometimes called GFS ( Grand Father / Father / Son) is a way to promote some backup to be kept on a long time that way , the user can use the find the best equilibrium between storage and security This commit add the code mechanics to indentify bakcup that can be deleted safely. It is intended to use with a form that ask the suer for the number of day, week, month, and year for which XO will keep the most recent It extends the actual system of keeping the n most recent backup Keep in mind that the backup oromoted by week and month can be decaled
| } | ||
| }) | ||
|
|
||
| describe('_getOldEntries() should fail when called incorrectly', () => {}) |
There was a problem hiding this comment.
Why doesn't it do anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long term retention sometimes called GFS ( Grand Father / Father / Son)
is a way to promote some backup to be kept on a long time
that way , the user can use the find the best equilibrium between
storage and security
This commit add the code mechanics to identify backups that
can be deleted safely. It is intended to use with a form
that ask the user for the number of day, week, month, and year
for which XO will keep the most recent
It extends the actual system of keeping the n most recent backup
Keep in mind that the backup promoted by week and month can be unaligned
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md