Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-core): update UiIcon component #8003

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat(xo-core): update UiIcon component #8003

merged 2 commits into from
Sep 25, 2024

Conversation

OlivierFL
Copy link
Collaborator

@OlivierFL OlivierFL commented Sep 23, 2024 •
edited
Loading

Description

Wait for #7994

  • Update variant prop name (color -> accent)
  • Add overlay-icon prop to enable stacking two icons (see screenshot below)
  • Update component name and CSS to match new component guidelines
  • Update component usages in XO 6 and XO Lite

Screenshots

icon-v2

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@OlivierFL OlivierFL self-assigned this Sep 23, 2024
@OlivierFL OlivierFL mentioned this pull request Sep 24, 2024
Merged
Base automatically changed from xo6/counter-component-v2 to master September 24, 2024 14:00
@MathieuRA MathieuRA merged commit 75684cb into master Sep 25, 2024
1 check passed
@MathieuRA MathieuRA deleted the xo6/add-stacked-icon-component branch September 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelissaFrncJrg MelissaFrncJrg MelissaFrncJrg approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees

@OlivierFL OlivierFL

Labels
XO Lite XO Web Core XO Web 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierFL @MathieuRA @MelissaFrncJrg