feat(web-core): added UiDropdownButton component #8076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0ris-K
force-pushed
the
xo6/dropdown-button
branch
2 times, most recently
from
7ae0578
to
f25a126
Compare
OlivierFL
requested changes
Oct 28, 2024
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
J0ris-K
force-pushed
the
xo6/dropdown-button
branch
2 times, most recently
from
af3a8d4
to
1e604ab
Compare
ByScripts
requested changes
Nov 5, 2024
| defineProps<{ | ||
| disabled?: boolean | ||
| selected?: boolean | ||
| leftIcon?: IconDefinition |
There was a problem hiding this comment.
Since it's the only possible prop icon, I'd suggest renaming leftIcon to icon.
Suggested change
| leftIcon?: IconDefinition | |
| icon?: IconDefinition |
Comment on lines
42
to
48
| position: relative; | ||
|
|
||
| .label, | ||
| .right-icon, | ||
| .left-icon { | ||
| color: var(--color-normal-txt-base); | ||
| } |
There was a problem hiding this comment.
I don't think it's necessary to target specific sub-items.
Suggested change
| position: relative; | |
| .label, | |
| .right-icon, | |
| .left-icon { | |
| color: var(--color-normal-txt-base); | |
| } | |
| position: relative; | |
| color: var(--color-normal-txt-base); |
Comment on lines
52
to
58
| background-color: var(--color-normal-background-hover); | ||
|
|
||
| .label, | ||
| .right-icon, | ||
| .left-icon { | ||
| color: var(--color-normal-txt-hover); | ||
| } |
There was a problem hiding this comment.
Suggested change
| background-color: var(--color-normal-background-hover); | |
| .label, | |
| .right-icon, | |
| .left-icon { | |
| color: var(--color-normal-txt-hover); | |
| } | |
| background-color: var(--color-normal-background-hover); | |
| color: var(--color-normal-txt-hover); |
Comment on lines
63
to
69
| background-color: var(--color-normal-background-active); | ||
|
|
||
| .label, | ||
| .right-icon, | ||
| .left-icon { | ||
| color: var(--color-normal-txt-active); | ||
| } |
There was a problem hiding this comment.
Suggested change
| background-color: var(--color-normal-background-active); | |
| .label, | |
| .right-icon, | |
| .left-icon { | |
| color: var(--color-normal-txt-active); | |
| } | |
| background-color: var(--color-normal-background-active); | |
| color: var(--color-normal-txt-active); |
Comment on lines
92
to
98
| background-color: var(--color-neutral-background-disabled); | ||
|
|
||
| .label, | ||
| .right-icon, | ||
| .left-icon { | ||
| color: var(--color-neutral-txt-secondary); | ||
| } |
There was a problem hiding this comment.
Suggested change
| background-color: var(--color-neutral-background-disabled); | |
| .label, | |
| .right-icon, | |
| .left-icon { | |
| color: var(--color-neutral-txt-secondary); | |
| } | |
| background-color: var(--color-neutral-background-disabled); | |
| color: var(--color-neutral-txt-secondary); |
Comment on lines
72
to
60
| &.selected { | ||
| border: 0.2rem solid var(--color-normal-txt-base); | ||
| background-color: var(--color-normal-background-selected); | ||
| } |
There was a problem hiding this comment.
Is it expected that .selected has no color setting?
There was a problem hiding this comment.
Yes because according to the DS the color of .selected is the same as idle
J0ris-K
force-pushed
the
xo6/dropdown-button
branch
from
1e604ab
to
fd6108f
Compare
OlivierFL
requested changes
Nov 12, 2024
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
@xen-orchestra/web-core/lib/components/ui/dropdown-button/UiDropdownButton.vue
Outdated
Show resolved
Hide resolved
J0ris-K
force-pushed
the
xo6/dropdown-button
branch
from
c2375c9
to
ae13401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added UiDropdownButton component
Screenshot
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: