Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-lite/network): add side panel informations and some trad #8150

Draft
wants to merge 9 commits into
base: lite/network-tab
Choose a base branch
from

Conversation

J0ris-K
Copy link
Contributor

@J0ris-K J0ris-K commented Nov 20, 2024

Description

Add side panel informations

Screenshot

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@J0ris-K J0ris-K self-assigned this Nov 20, 2024
@J0ris-K J0ris-K changed the base branch from master to lite/network-tab November 20, 2024 16:39
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch from fbc66f0 to 27474c3 Compare November 21, 2024 11:37
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch 2 times, most recently from 4f33810 to 8dd3bce Compare November 26, 2024 17:14
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch 3 times, most recently from 2a9fb7d to 3b8e7cb Compare November 27, 2024 07:46
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch from 3b8e7cb to 1b3ce98 Compare December 4, 2024 14:13
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch 2 times, most recently from a8c9968 to bcbcfcb Compare December 4, 2024 16:48
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch 2 times, most recently from 69a064f to da7275a Compare December 12, 2024 21:08
@J0ris-K J0ris-K requested a review from OlivierFL December 12, 2024 21:11
@J0ris-K J0ris-K force-pushed the lite/network-tab-sidepanel branch from da7275a to f57975b Compare December 12, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant