Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cloudbase-init documentation #8173

Merged
merged 2 commits into from
Dec 19, 2024
Merged

docs: cloudbase-init documentation #8173

merged 2 commits into from
Dec 19, 2024

Conversation

thomas-dkmt
Copy link
Contributor

@thomas-dkmt thomas-dkmt commented Dec 2, 2024

As of release 5.101, Xen Orchestra supports Cloudbase-init (for Windows VMs), on top of the already-supported Cloud-init (for Linux VMs).

The Cloud-init section is therefore expanded to mention Cloudbase-init, and we explain how to create a template for Windows VMs using Cloudbase-init.

For more information, see the Xen Orchestra 5.101 blog post.

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

Xen Orchestra now supports Cloudbase-init (for Windows VMs),
on top of the already-supported Cloud-init (for Linux VMs).
The Cloud-init section is therefore expanded to mention Cloudbase-init,
and we explain how to create a template for Windows VMs using Cloudbase-init.

Signed-off-by: Thomas Moraine <[email protected]>
@MathieuRA MathieuRA requested a review from stormi December 3, 2024 13:52
@stormi
Copy link
Collaborator

stormi commented Dec 3, 2024

What is there for me to review?

@MathieuRA MathieuRA changed the title Xen Orchestra documentation: Cloudbase-init support docs: cloudbase-init documentation Dec 4, 2024
@olivierlambert olivierlambert requested review from olivierlambert and removed request for stormi December 6, 2024 08:05
@MathieuRA MathieuRA merged commit 2f2a0ae into master Dec 19, 2024
1 check passed
@MathieuRA MathieuRA deleted the doc-cloudbaseinit branch December 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants